comaniac commented on a change in pull request #6042:
URL: https://github.com/apache/incubator-tvm/pull/6042#discussion_r453778990



##########
File path: src/tir/transforms/unroll_loop.cc
##########
@@ -57,6 +58,9 @@ struct UnrollLoopConfigNode : public 
tvm::AttrsNode<UnrollLoopConfigNode> {
     TVM_ATTR_FIELD(explicit_unroll)
         .describe("Whether to explicitly unroll the loop instead of setting a 
pragma")
         .set_default(true);
+    TVM_ATTR_FIELD(explicit_unroll_max_extent)
+        .describe("The maximum extent of a loop that can be unrolled 
explicitly (-1 for infinite)")
+        .set_default(32);

Review comment:
       What's the performance impact of 16 on X86? Should we check the related 
TOPI templates, including X86 and ARM, for the performance impact?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to