d-smirnov commented on a change in pull request #6018:
URL: https://github.com/apache/incubator-tvm/pull/6018#discussion_r454582120
##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -358,12 +358,16 @@ def has_same_qnn_params(self, lhs_tensor, rhs_tensor):
rhs_scale = rhs_tensor.qnn_params['scale']
lhs_zero_point = lhs_tensor.qnn_params['zero_point']
rhs_zero_point = rhs_tensor.qnn_params['zero_point']
- lhs_scale_value = get_scalar_from_constant(lhs_scale)
- rhs_scale_value = get_scalar_from_constant(rhs_scale)
- lhs_zero_point_value = get_scalar_from_constant(lhs_zero_point)
- rhs_zero_point_value = get_scalar_from_constant(rhs_zero_point)
- return lhs_scale_value == rhs_scale_value and \
- lhs_zero_point_value == rhs_zero_point_value
+ # 0.1 + 0.2 != 0.3
Review comment:
The main point here is a replacement of exact comparison of floating
point values with the inexact ones. The extension of the function to tuples is
sort of a bonus from numpy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
