icemelon9 commented on a change in pull request #6052:
URL: https://github.com/apache/incubator-tvm/pull/6052#discussion_r454666904
##########
File path: include/tvm/relay/dataflow_matcher.h
##########
@@ -42,11 +42,16 @@ class DFPatternCallback;
class DFPatternCallbackNode : public Object {
public:
/*! \brief Pattern this callback matches */
- DFPattern pattern_;
+ DFPattern pattern;
/*! \brief Function to call when finding a matched expression */
- PackedFunc function_;
+ PackedFunc function;
+ /*! \brief Require InferType to be run before the callback */
+ bool require_type;
Review comment:
Because these variables are public, it's probably better and more
consistent to name it without "_" at the end imo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
