poyenc opened a new issue #6074:
URL: https://github.com/apache/incubator-tvm/issues/6074


   ## Issue
   In 
[`SequentialNode::operator()`](https://github.com/apache/incubator-tvm/blob/8578096853eec5711bfcc9a3a68145fd12a135cb/src/ir/transform.cc#L364),
 before execute each passes, we do not check if their own dependency passes are 
all enabled:
   
   ```c++
   IRModule SequentialNode::operator()(IRModule mod, const PassContext& 
pass_ctx) const {
     for (const Pass& pass : passes) {
       CHECK(pass.defined()) << "Found undefined pass for optimization.";
       const PassInfo& pass_info = pass->Info();
       if (!PassEnabled(pass_info)) continue; // THE PROBLEM: only check pass 
itself
       // resolve dependencies
       for (const auto& it : pass_info->required) {
         mod = GetPass(it)(std::move(mod), pass_ctx);
       }
       mod = pass(std::move(mod), pass_ctx);
     }
     return mod;
   }
   ```
   
   ## Suggetion
   In loop show above, add 
[`PassEnabled()`](https://github.com/apache/incubator-tvm/blob/8578096853eec5711bfcc9a3a68145fd12a135cb/src/ir/transform.cc#L334)
 call for all dependecny passes
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to