nhynes commented on a change in pull request #5892: URL: https://github.com/apache/incubator-tvm/pull/5892#discussion_r458315283
########## File path: apps/wasm-standalone/wasm-graph/src/utils.rs ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +use super::types::*; +use serde_json; +use std::ptr; + +pub fn load_input(in_addr: i32, in_size: usize) -> Tensor { Review comment: > I'm afraid the memory errors would be difficult to debug What? This function is semantically unsafe, therefore it should be `pub unsafe fn load_input`. The point is to make the places where it's called self-documenting. ########## File path: apps/wasm-standalone/wasm-graph/src/utils.rs ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +use super::types::*; +use serde_json; +use std::ptr; + +pub fn load_input(in_addr: i32, in_size: usize) -> Tensor { Review comment: > I'm afraid the memory errors would be difficult to debug What? This function is semantically unsafe, therefore it should be `pub unsafe fn load_input`. The point is to make the places where it's called self-documenting. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
