kazum commented on a change in pull request #6116:
URL: https://github.com/apache/incubator-tvm/pull/6116#discussion_r459278406
##########
File path: rust/tvm-sys/Cargo.toml
##########
@@ -32,4 +32,4 @@ ndarray = "0.12"
enumn = "^0.1"
[build-dependencies]
-bindgen = "0.51"
+bindgen = { version="0.51", default-features=false }
Review comment:
It was necessary before, but now I confirm wasm32 can be compiled
successfully without it. I'm not sure why.
@binarybana Could you revive a wasm32 test to make sure that this PR doesn't
break wasm32 build?
```diff
diff --git a/tests/scripts/task_rust.sh b/tests/scripts/task_rust.sh
index 6d159f6..7cdfb1a 100755
--- a/tests/scripts/task_rust.sh
+++ b/tests/scripts/task_rust.sh
@@ -71,11 +71,11 @@ cd tests/test_tvm_dso
cargo run
cd -
-# # run wasm32 test
-# cd tests/test_wasm32
-# cargo build
+# run wasm32 test
+cd tests/test_wasm32
+cargo build
# wasmtime $RUST_DIR/target/wasm32-wasi/debug/test-wasm32.wasm
-# cd -
+cd -
# run nn graph test
cd tests/test_nn
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
