comaniac commented on pull request #6112: URL: https://github.com/apache/incubator-tvm/pull/6112#issuecomment-663678802
Thanks for the PR! Since CLI itself serves as an infra, it would be better to break this PR to a series of PRs like the following: - PR1: The basic CLI infra mainly including 1) CLI setup, 2) the registration mechanism, and 3) the document. - PR2: CLI -- compile. - PR3: CLI -- run. - PR4: CLI -- tune. In this way, people can focus on the overall CLI infra in the first PR. Once everyone is happy with it, the rest PRs would have a much clearer scope. For example, "CLI -- compile" would attract people who are familiar with compilation flow. In this way, we can expect the following advantages: 1. We can focus on what functions/options should be included in a scope. 2. We can focus on the implementation of those functions/options in each scope. For example, I've seen many redundant/similar functions implemented in `tvmc` and I believe some of them should reuse the existing ones in TVM. 3. The CLI PRs can be sent and reviewed in parallel, and they won't block each other. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
