csullivan commented on a change in pull request #6085:
URL: https://github.com/apache/incubator-tvm/pull/6085#discussion_r460449924
##########
File path: python/tvm/relay/frontend/tensorflow.py
##########
@@ -637,10 +637,11 @@ def _impl(inputs, attr, params, mod):
iou_threshold = np.atleast_1d(inputs[3].data.asnumpy())[0]
# score_threshold was introduced from V3
score_threshold = np.atleast_1d(inputs[4].data.asnumpy())[0] if
len(inputs) > 4 else 0.0
+ pad_output = 'pad_to_max_output_size'
# Generate data with shape (1, num_anchors, 5)
scores = AttrCvt(op_name="expand_dims",
- ignores=['T_threshold'],
+ ignores=['T_threshold', pad_output],
Review comment:
It's not ignored, this PR adds explicit support to `__nms()` for the
`pad_to_max_output_size=True` case, see lines 671/2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
