wrongtest commented on a change in pull request #6062:
URL: https://github.com/apache/incubator-tvm/pull/6062#discussion_r460616511



##########
File path: include/tvm/relay/transform.h
##########
@@ -223,10 +223,12 @@ TVM_DLL Pass CombineParallelConv2D(uint64_t 
min_num_branches = 3);
  * `min_num_branch`.
  *
  * \param min_num_branches The minimun number of branches.
+ * \param to_batch_matmul Whether combine parallel dense ops to batch matmul.

Review comment:
       Hi, I don't quite understand here ` "CombineParallel instead of Batch"`, 
means we could just rename the pass like `BatchingOps` ?  I can work to wrap 
current 3 CombineParallelXXX pass into a sequential. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to