jcf94 commented on a change in pull request #6141:
URL: https://github.com/apache/incubator-tvm/pull/6141#discussion_r460680154
##########
File path: src/auto_scheduler/transform_step.cc
##########
@@ -967,11 +1162,27 @@ String
ComputeRootStepNode::PrintAsPythonAPI(Array<te::Stage>* stages,
*/
Array<Step> GetFormerStageModifiableSteps(Step current_step, const
Array<Step>& transform_steps) {
Array<Step> ret_steps;
- for (const Step& step : transform_steps) {
+ for (size_t i = 0; i < transform_steps.size(); ++i) {
+ const Step& step = transform_steps[i];
if (step->IsInstance<CacheWriteStepNode>() ||
step->IsInstance<CacheReadStepNode>()) {
ret_steps.push_back(step);
+ } else if (step->IsInstance<RfactorStepNode>()) {
+ // add FuseStepNode required by rfactor
+ if (i >= 2 && transform_steps[i - 2]->IsInstance<FuseStepNode>()) {
+ const Step& fuse_step = transform_steps[i - 2];
+ if (fuse_step->stage_id == step->stage_id) {
+ ret_steps.push_back(fuse_step);
+ }
+ }
+ // add SplitStepNode required by rfactor
+ CHECK_GE(i, 1);
+ CHECK(transform_steps[i - 1]->IsInstance<SplitStepNode>());
+ const Step& split_step = transform_steps[i - 1];
+ CHECK_EQ(split_step->stage_id, step->stage_id);
+ ret_steps.push_back(split_step);
+ // add RfactorStepNode
+ ret_steps.push_back(step);
Review comment:
These checks here are specialized for the Rfactor in our search policy,
will the rules continue to be kept like this?
##########
File path: src/auto_scheduler/transform_step.cc
##########
@@ -967,11 +1162,27 @@ String
ComputeRootStepNode::PrintAsPythonAPI(Array<te::Stage>* stages,
*/
Array<Step> GetFormerStageModifiableSteps(Step current_step, const
Array<Step>& transform_steps) {
Array<Step> ret_steps;
- for (const Step& step : transform_steps) {
+ for (size_t i = 0; i < transform_steps.size(); ++i) {
+ const Step& step = transform_steps[i];
if (step->IsInstance<CacheWriteStepNode>() ||
step->IsInstance<CacheReadStepNode>()) {
ret_steps.push_back(step);
+ } else if (step->IsInstance<RfactorStepNode>()) {
+ // add FuseStepNode required by rfactor
+ if (i >= 2 && transform_steps[i - 2]->IsInstance<FuseStepNode>()) {
+ const Step& fuse_step = transform_steps[i - 2];
+ if (fuse_step->stage_id == step->stage_id) {
+ ret_steps.push_back(fuse_step);
+ }
+ }
+ // add SplitStepNode required by rfactor
+ CHECK_GE(i, 1);
+ CHECK(transform_steps[i - 1]->IsInstance<SplitStepNode>());
+ const Step& split_step = transform_steps[i - 1];
+ CHECK_EQ(split_step->stage_id, step->stage_id);
+ ret_steps.push_back(split_step);
+ // add RfactorStepNode
+ ret_steps.push_back(step);
Review comment:
These checks here are specialized for the Rfactor in our search policy,
will the rules continue to be kept like this? @merrymercy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
