tqchen commented on a change in pull request #6078:
URL: https://github.com/apache/incubator-tvm/pull/6078#discussion_r462011402
##########
File path: include/tvm/arith/int_solver.h
##########
@@ -41,6 +41,11 @@ using tir::IterVar;
using tir::Var;
using tir::VarNode;
+// According to experiments two best simplifications orders were can->rw and
rw->can->rw,
+// but rw->can->rw is better for a couple of cases.
+// Also we should end with rw because it factors multipliers out.
+#define ARITH_SIMPLIFY_REWRITE_CANONICAL_REWRITE 3
Review comment:
use constexpr int instead of macro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
