liangfu commented on a change in pull request #6145:
URL: https://github.com/apache/incubator-tvm/pull/6145#discussion_r464055086
##########
File path: apps/bundle_deploy/Makefile
##########
@@ -42,76 +43,70 @@ demo_dynamic: $(build_dir)/demo_dynamic
$(build_dir)/bundle.so $(build_dir)/bund
TVM_NUM_THREADS=1 $(build_dir)/demo_dynamic $(build_dir)/bundle.so
$(build_dir)/cat.bin
TVM_NUM_THREADS=1 $(build_dir)/demo_dynamic $(build_dir)/bundle_c.so
$(build_dir)/cat.bin
-test_dynamic: $(build_dir)/test_dynamic $(build_dir)/test_bundle.so
$(build_dir)/test_bundle_c.so $(build_dir)/test_data.bin
$(build_dir)/test_output.bin
- TVM_NUM_THREADS=1 $(build_dir)/test_dynamic $(build_dir)/test_bundle.so
$(build_dir)/test_data.bin $(build_dir)/test_output.bin
$(build_dir)/test_graph.json $(build_dir)/test_params.bin
- TVM_NUM_THREADS=1 $(build_dir)/test_dynamic
$(build_dir)/test_bundle_c.so $(build_dir)/test_data.bin
$(build_dir)/test_output.bin $(build_dir)/test_graph.json
$(build_dir)/test_params.bin
+test_dynamic: $(build_dir)/test_dynamic $(build_dir)/test_bundle.so
$(build_dir)/test_bundle_c.so $(build_dir)/test_data_c.bin
$(build_dir)/test_output_c.bin $(build_dir)/test_data_cpp.bin
$(build_dir)/test_output_cpp.bin
+ TVM_NUM_THREADS=1 $(build_dir)/test_dynamic $(build_dir)/test_bundle.so
$(build_dir)/test_data_cpp.bin $(build_dir)/test_output_cpp.bin
$(build_dir)/test_graph_cpp.json $(build_dir)/test_params_cpp.bin
+ TVM_NUM_THREADS=1 $(build_dir)/test_dynamic
$(build_dir)/test_bundle_c.so $(build_dir)/test_data_c.bin
$(build_dir)/test_output_c.bin $(build_dir)/test_graph_c.json
$(build_dir)/test_params_c.bin
demo_static: $(build_dir)/demo_static $(build_dir)/cat.bin
TVM_NUM_THREADS=1 $(build_dir)/demo_static $(build_dir)/cat.bin
-test_static: $(build_dir)/test_static $(build_dir)/test_data.bin
$(build_dir)/test_output.bin
- TVM_NUM_THREADS=1 $(build_dir)/test_static $(build_dir)/test_data.bin
$(build_dir)/test_output.bin $(build_dir)/test_graph.json
$(build_dir)/test_params.bin
+test_static: $(build_dir)/test_static $(build_dir)/test_data_c.bin
$(build_dir)/test_output_c.bin
+ TVM_NUM_THREADS=1 $(build_dir)/test_static $(build_dir)/test_data_c.bin
$(build_dir)/test_output_c.bin $(build_dir)/test_graph_c.json
$(build_dir)/test_params_c.bin
$(build_dir)/crt/graph_runtime/libgraph_runtime.a:
- cd $(CRT_ROOT) && make QUIET= BUILD_DIR=$(abspath $(build_dir))/crt
CRT_CONFIG=$(abspath crt_config/crt_config.h) graph_runtime
+ cd $(CRT_ROOT) && make QUIET= BUILD_DIR=$(abspath $(build_dir))/crt
CRT_CONFIG=$(abspath crt_config/crt_config.h)
"EXTRA_CFLAGS=$(PKG_COMPILE_OPTS)" graph_runtime
$(build_dir)/crt/common/libcommon.a:
- cd $(CRT_ROOT) && make QUIET= BUILD_DIR=$(abspath $(build_dir))/crt
CRT_CONFIG=$(abspath crt_config/crt_config.h) common
+ cd $(CRT_ROOT) && make QUIET= BUILD_DIR=$(abspath $(build_dir))/crt
CRT_CONFIG=$(abspath crt_config/crt_config.h)
"EXTRA_CFLAGS=$(PKG_COMPILE_OPTS)" common
-$(build_dir)/demo_dynamic: demo.cc ${build_dir}/graph.json.c
${build_dir}/params.bin.c
+$(build_dir)/demo_dynamic: demo.cc ${build_dir}/graph_c.json.c
${build_dir}/params_c.bin.c
@mkdir -p $(@D)
g++ $(PKG_CXXFLAGS) -o $@ demo.cc -ldl
-$(build_dir)/test_dynamic: test.cc ${build_dir}/test_graph.json
${build_dir}/test_params.bin
+$(build_dir)/test_dynamic: test.cc ${build_dir}/test_graph_c.json
${build_dir}/test_params_c.bin
@mkdir -p $(@D)
g++ $(PKG_CXXFLAGS) -o $@ test.cc -ldl
-$(build_dir)/model.o: $(build_dir)/model.c
- gcc $(PKG_CFLAGS) -c -o $@ $^
-
-$(build_dir)/demo_static: demo_static.c ${build_dir}/bundle_static.o
${build_dir}/func_registry.c ${build_dir}/model.o ${build_dir}/graph.json.c
${build_dir}/params.bin.c ${build_dir}/crt/graph_runtime/libgraph_runtime.a
${build_dir}/crt/common/libcommon.a
+$(build_dir)/demo_static: demo_static.c ${build_dir}/bundle_static.o
${build_dir}/model_c.o ${build_dir}/graph_c.json.c ${build_dir}/params_c.bin.c
${build_dir}/crt/graph_runtime/libgraph_runtime.a
${build_dir}/crt/common/libcommon.a
@mkdir -p $(@D)
- gcc $(PKG_CFLAGS) -o $@ demo_static.c ${build_dir}/bundle_static.o
${build_dir}/func_registry.c ${build_dir}/model.o -lm
${build_dir}/crt/graph_runtime/libgraph_runtime.a
${build_dir}/crt/common/libcommon.a
+ gcc $(PKG_CFLAGS) -o $@ demo_static.c ${build_dir}/bundle_static.o
${build_dir}/model.o -lm ${build_dir}/crt/graph_runtime/libgraph_runtime.a
${build_dir}/crt/common/libcommon.a
-$(build_dir)/test_static: test_static.c ${build_dir}/bundle_static.o
${build_dir}/test_func_registry.c ${build_dir}/test_model.o
${build_dir}/crt/graph_runtime/libgraph_runtime.a
${build_dir}/crt/common/libcommon.a
+$(build_dir)/test_static: test_static.c ${build_dir}/bundle_static.o
${build_dir}/test_model_c.o ${build_dir}/crt/graph_runtime/libgraph_runtime.a
${build_dir}/crt/common/libcommon.a
@mkdir -p $(@D)
- gcc $(PKG_CFLAGS) -o $@ $^
+ gcc $(PKG_CFLAGS) -o $@ $^ -ldl
Review comment:
I think linking to `dl` library within a static target isn't the desired
intention. @mehrdadh what's your take on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
