FrozenGene commented on a change in pull request #6196:
URL: https://github.com/apache/incubator-tvm/pull/6196#discussion_r464416067
##########
File path: python/tvm/relay/frontend/coreml.py
##########
@@ -350,6 +350,33 @@ def _MinLayerParams(op, inexpr, etab):
return _min
+def _UnaryFunctionLayerParams(op, inexpr, etab):
+ op_type = op.type
+ if op_type == 0:
Review comment:
Let us not use `0` / `1` / `2` ... directly. We could use `
op.THRESHOLD` / `op.EXP` and so on. See
https://apple.github.io/coremltools/coremlspecification/sections/NeuralNetwork.html#unaryfunctionlayerparams
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
