ANSHUMAN87 commented on pull request #6066: URL: https://github.com/apache/incubator-tvm/pull/6066#issuecomment-668167439
@kevinthesun : Thanks for your response! I am familiar with the scenario you are referring for conv op. I agree to the possibilities of hoisting in that case. The same concern was raised by @roastduck too, i believe. Unfortunately due to some intermediate pass dependency on the positioning of For and If node, i temporarily disabled this hoisting scenario with Attr nodes(IterVar & GlobalVar). I think it would be better, i enable this hoisting scenario too and move the position of Hoisting Pass to the end of list during lowering. May be after that we can take the performance data. Please let me know your opinion on this. TIA! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
