cbalint13 edited a comment on pull request #6204:
URL: https://github.com/apache/incubator-tvm/pull/6204#issuecomment-668506828


   > i suppose there are two ways to solve:
   > 
   > 1. add some pragma  to inhibit this warning
   > 2. neither rely on move nor rvo,  just refactor the AttrInitEntry , add 
ref counted internal state to delay destructor, as codes showing bellow
   >    https://gist.github.com/hanzz2007/803b28a7915c31686cffce0ac6450b73
   >    https://gist.github.com/hanzz2007/e42b14b51c8c9c765cca107867e64d49
   
   @hanzz2007 , @MarisaKirisame 
   
   
   * Updated PR, added a GCC specific single-line effect pragma for now.
   * I myself like **2nd** solution (clean & readable & trackable) but 
@hanzz2007 please make it in a separate PR.
   
   Thank You !
   
   PS: :sweat_smile: 
   *  Ended up with 2x pragma:  one silence "too dumb" (old CI GCC), second 
waves the "too smart" (latest GCC)
   *  Beside CI, can confirm that PR is fine now with GCC 10.2.1 too, "the 
pessimistic" have zero warnings now.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to