abergeron commented on a change in pull request #6065:
URL: https://github.com/apache/incubator-tvm/pull/6065#discussion_r465176524
##########
File path: topi/tests/python/test_topi_conv3d_transpose_ncdhw.py
##########
@@ -86,15 +86,18 @@ def check_device(device):
def test_conv3d_transpose_ncdhw():
- verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 1, (1, 1, 1), (1, 1,
1), (0, 0, 0, 0, 0, 0))
- verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 2, (3, 3, 3), (1, 1, 1),
(0, 0, 0, 0, 0, 0))
- verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 16, (3, 3, 3), (1, 1,
1), (0, 0, 0, 0, 0, 0))
- verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 16, (3, 3, 3), (3, 3,
3), (0, 0, 0, 0, 0, 0))
- verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 16, (3, 3, 3), (1, 1,
1), (0, 0, 0, 0, 0, 0))
- verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 16, (3, 3, 3), (2, 2,
2), (1, 1, 1, 1, 1, 1))
- verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 16, (2, 2, 2), (2, 2,
2), (0, 0, 0, 0, 0, 0))
- verify_conv3d_transpose_ncdhw(1, 8, (32, 32, 32), 32, (5, 5, 5), (1, 1,
1), (0, 0, 0, 0, 0, 0))
- verify_conv3d_transpose_ncdhw(1, 8, (32, 32, 32), 64, (5, 5, 5), (2, 2,
2), (1, 1, 1, 1, 1, 1))
+ verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 1, (1, 1, 1), (1, 1,
1), (0, 0, 0, 0, 0, 0), (0, 0, 0))
+ verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 2, (3, 3, 3), (1, 1, 1),
(0, 0, 0, 0, 0, 0), (0, 0, 0))
+ verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 16, (3, 3, 3), (1, 1,
1), (0, 0, 0, 0, 0, 0), (0, 0, 0))
+ verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 16, (3, 3, 3), (3, 3,
3), (0, 0, 0, 0, 0, 0), (0, 0, 0))
+ verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 16, (3, 3, 3), (3, 3,
3), (0, 0, 0, 0, 0, 0), (2, 2, 2))
+ #verify_conv3d_transpose_ncdhw(1, 3, (24, 24, 24), 16, (3, 3, 3), (3, 3,
3), (0, 0, 0, 0, 0, 0), (1, 0, 2))
Review comment:
Yes it is broken.
I don't remember how exactly but I think the original function doesn't work
correctly when the shapes are not all the same. None of the current tests
check for that. I might take some time to figure out why right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
