csullivan commented on pull request #6216:
URL: https://github.com/apache/incubator-tvm/pull/6216#issuecomment-669740080


   Your concern is valid. What I observed that motivated this PR: After the 
timeout is reached** the RPCActivity view (with the StopRPC button) will close 
and return to the MainActivity view where the connection fields are listed. 
After a short time the RPCActivity will automatically restart and the pending 
measurements will again decrease. This seems to be the desired behavior. 
   
   I can run a few experiments tomorrow to be sure, however, unfortunately 
while this helped stability, after about an hour or two I did see a system 
reset of similar characteristics as before. The resets are much less frequent 
than before, but persist. I noted two more uses of System.exit() in the 
RPCTracker APK which may or may not be causing this behavior:
   
   
https://github.com/apache/incubator-tvm/blob/master/apps/android_rpc/app/src/main/java/org/apache/tvm/tvmrpc/RPCActivity.java#L44
   
   
https://github.com/apache/incubator-tvm/blob/master/apps/android_rpc/app/src/main/java/org/apache/tvm/tvmrpc/RPCProcessor.java#L54
   
   ** Approximating here as I counted from when I saw the pending measurements 
stall


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to