FrozenGene commented on a change in pull request #6223:
URL: https://github.com/apache/incubator-tvm/pull/6223#discussion_r466338957
##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -2886,6 +2887,56 @@ def convert_detection_postprocess(self, op):
ret = _expr.TupleWrapper(_expr.Tuple([boxes, cls_ids, scores,
valid_count]), size=4)
return ret
+ def convert_one_hot(self, op):
+ """Convert TFLite ONE_HOT"""
+ try:
+ from tflite.BuiltinOptions import BuiltinOptions
+ from tflite.OneHotOptions import OneHotOptions
+ except ImportError:
+ raise ImportError("The tflite package must be installed")
+
+ input_tensors = self.get_input_tensors(op)
+ assert len(input_tensors) == 4, "Input tensor's length should be 4"
+
+ # Ensuring input isn't quantized
+ for t in input_tensors:
+ assert not t.qnn_params, "Quantized input is not expected."
Review comment:
we could use `assert all(not i.qnn_params for i in input_tensors)`
##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -2886,6 +2887,56 @@ def convert_detection_postprocess(self, op):
ret = _expr.TupleWrapper(_expr.Tuple([boxes, cls_ids, scores,
valid_count]), size=4)
return ret
+ def convert_one_hot(self, op):
+ """Convert TFLite ONE_HOT"""
+ try:
+ from tflite.BuiltinOptions import BuiltinOptions
+ from tflite.OneHotOptions import OneHotOptions
+ except ImportError:
+ raise ImportError("The tflite package must be installed")
+
+ input_tensors = self.get_input_tensors(op)
+ assert len(input_tensors) == 4, "Input tensor's length should be 4"
+
+ # Ensuring input isn't quantized
+ for t in input_tensors:
+ assert not t.qnn_params, "Quantized input is not expected."
+
+ # TFlite ONE_HOT requires both on_value
+ # and off_value, making dtype redundant.
+ indices = input_tensors[0]
+ depth = input_tensors[1]
+ on_value = input_tensors[2]
+ off_value = input_tensors[3]
+
+ assert on_value.tensor.Type() == off_value.tensor.Type(), \
+ "on_value and off_value should be of the same type"
Review comment:
no `of`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
