windclarion opened a new pull request #6231: URL: https://github.com/apache/incubator-tvm/pull/6231
1. include\tvm\runtime\crt\module.h function TVMSystemLibEntryPoint need extern "C", or else linker complain this symbol can't be found. 2. src\target\source\codegen_c_host.cc function GenerateFuncRegistry: f need cast, or else C++ compiler say type not match L291 array _tvm_func_array miss "};", so build fail system_lib_registry and system_lib name need use new name in PR #6145 3. src\support\str_escape.h function StrEscape convert to octal need 3bit, but unsigned char c only use LSB 2bit, because mask macro is 0x03, should be 0x07. '0' + ((c >> 6) & 0x03) need cast to unsigned char, because ostringstream treat it as int, not unsigned char, so value is error. ex. c = 0x17, means we have 23 functions to register, so ((c >> 6) & 0x03) == 0, and '0' + ((c >> 6) & 0x03) is the int value of '0', which is 48, but ostringstream treat it as int, so we get a string "485055", in fact it should be "027" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
