kevinthesun commented on a change in pull request #6024:
URL: https://github.com/apache/incubator-tvm/pull/6024#discussion_r469430653



##########
File path: python/tvm/relay/frontend/tensorflow.py
##########
@@ -1458,6 +1458,15 @@ def _impl(inputs, attr, params, mod):
 
                 return ret
 
+        def _dyn():
+            for d in data_shape:
+                if not isinstance(d, int):
+                    return True
+            return False
+
+        if _dyn():

Review comment:
       We can use shape_of to get data shape. In this case all shape dim will 
be relay expression and transform mask should be able to handle them. Anyway I 
don't think we should silently skip it since the output can be wrong and cause 
latter type infer error.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to