lhutton1 commented on a change in pull request #6254:
URL: https://github.com/apache/incubator-tvm/pull/6254#discussion_r469832156
##########
File path: python/tvm/relay/op/contrib/arm_compute_lib.py
##########
@@ -114,8 +141,26 @@ def check_qnn_conv(extract):
call = call.args[0]
return qnn_conv2d(call.attrs, call.args)
+ def check_dense(extract):
+ """Check conv pattern is supported by ACL."""
+ call = extract
Review comment:
The out_dtype attribute check is actually on the requantize node. The
first node in the extract for fp32 would be nn.bias_add which doesn't have the
out_dtype attribute. The out_dtype is checked though in the dense function
below. Hope that makes sense :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
