leandron commented on a change in pull request #6278:
URL: https://github.com/apache/incubator-tvm/pull/6278#discussion_r470484784
##########
File path: tests/python/frontend/keras/test_forward.py
##########
@@ -182,6 +182,7 @@ def test_forward_activations(self, keras):
x = act_func(data)
keras_model = keras.models.Model(data, x)
verify_keras_frontend(keras_model)
+ verify_keras_frontend(keras_model, False, 'NHWC')
Review comment:
minor suggestion: `verify_keras_frontend` will automatically set
`need_transpose` to `false` when the layout is not `NCHW`. So in this case if
you want to make it explicit, I suggest naming the parameters.
```
verify_keras_frontend(keras_model, need_transpose=False, layout='NHWC')
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
