mbrookhart commented on a change in pull request #6272:
URL: https://github.com/apache/incubator-tvm/pull/6272#discussion_r470746250



##########
File path: src/relay/transforms/pattern_util.h
##########
@@ -374,7 +374,7 @@ inline bool IsEqualScalar(const Expr& a, const Expr& b) {
  * \param i element index
  * \return Converted scalar value.
  */
-static inline double ToScalar(const runtime::NDArray& array, size_t i = 0) {
+static inline long double ToScalar(const runtime::NDArray& array, size_t i = 
0) {

Review comment:
       Because a double only has 52 bits of mantissa, it can't store the full 
precision of an int64_t.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to