comaniac commented on pull request #6279: URL: https://github.com/apache/incubator-tvm/pull/6279#issuecomment-674175010
`TVM_ARM_RPC_*` is confusing, especially it is only used by the testing infra. IMHO, `TVM_TEST_ARM_RPC_*` would be slightly better. On the other hand, `TVM_RPC_*` seems too general. I don't think we need a series of `TVM_RPC_*` environment variables to control the RPC setting else where. Meanwhile, I am not a fan of this style to be honest. From the unit test and CI point of view we should not depend on environment variables if we don't have to. Would like to hear from other's opinions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
