comaniac commented on pull request #6286: URL: https://github.com/apache/incubator-tvm/pull/6286#issuecomment-674687125
Hey thanks for the change. I agree with your methodology that we could customize the libinfo to deliver whatever we want. Apparently, it's impractical to parse camel.config and we have to manually setup the libinfo. With this statement, we should be able to have more flexibility in libinfo. For example, we even don't need USE_LLVM, USE_CUDA corresponding to cmake flags, but just need LLVM_VERSION, CUDA_VERSION. I think it's worthwhile to have an RFC discussing the libinfo contents (or we could refer to a previous RFC about benchmarking guidelines). However, this PR is a good start and shouldn't be blocked by this topic. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
