kevinthesun commented on a change in pull request #6318:
URL: https://github.com/apache/incubator-tvm/pull/6318#discussion_r474894730
##########
File path: python/tvm/relay/frontend/pytorch.py
##########
@@ -1755,6 +1757,50 @@ def _impl(inputs, input_types):
return _impl
+def _index():
+ def _impl(inputs, input_types):
+ data = inputs[0]
+ indices = []
+ raw_indices = []
+ max_indices_len = -1
+ for index in inputs[1]:
+ if not isinstance(index, _expr.Constant):
+ try:
+ index = _expr.const(_infer_value(index, {}))
+ except Exception:
+ raise RuntimeError("Only supports constant indices for "
+ "pytorch advanced indexing ")
+ raw_indices.append(index)
+ cindex_len = index.data.shape[0]
+ if cindex_len > max_indices_len:
+ max_indices_len = cindex_len
+
+ for index in raw_indices:
+ cnp = index.data.asnumpy()
+ cindex_len = cnp.shape[0]
+ if cindex_len < max_indices_len:
+ cnp = np.tile(cnp, max_indices_len // cindex_len)
+ indices.append(cnp)
+
+ ret = []
+ slice_map = {}
+ for i in range(indices[0].shape[0]):
+ tmp = data
+ current_indices = []
+ for index in indices:
+ current_indices.append(index[i])
+ index_key = tuple(current_indices)
+ if index_key in slice_map:
+ tmp = slice_map[index_key]
+ else:
+ tmp = _op.take(tmp, _expr.const(index[i]), axis=0)
Review comment:
In most cases it should be fine, but we can definitely improve it by
adding a new topi implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]