mbrookhart commented on a change in pull request #6316:
URL: https://github.com/apache/incubator-tvm/pull/6316#discussion_r475819380



##########
File path: python/tvm/relay/op/_transform.py
##########
@@ -165,6 +138,8 @@ def _strided_slice_shape_func_input_shape(data_shape, 
begin, end, strides, slice
             cstride = int64(strides[i])
         if len(begin) > i:
             cbegin = int64(begin[i])
+            if cbegin < 0:
+                cbegin += int64(data_shape[i])

Review comment:
       I attempted to do this with an assert in the hybrid script, but 
something seems a little off in the compiler, even after these lines it was 
still checking against the original value.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to