tqchen commented on a change in pull request #6331:
URL: https://github.com/apache/incubator-tvm/pull/6331#discussion_r475851274
##########
File path: tests/scripts/setup-pytest-env.sh
##########
@@ -26,5 +26,20 @@ else
fi
set -u
+export TVM_TEST_DEVICES=""
+while test $# -gt 0
+do
+ case "$1" in
+ cpu) export TVM_TEST_DEVICES="llvm;llvm
-device=arm_cpu;$TVM_TEST_DEVICES"
+ ;;
Review comment:
I feel it is a bit overly complicated to have two level of directions
here:
- D0: arguments in the test script
- D1: env variable(TVM_TEST_DEVICES)
- D2: pytest flag.
It would be awsome if we can reduce it to a single level e.g. an environment
variable, and ensure good default behavior so that we can:
- Directly run a specific test via pytest without worrying about setting up
the env and run setup-pytest-denv
- Have good default when nothing is set (e.g. run everything that is
available).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
