MarisaKirisame commented on a change in pull request #5881:
URL: https://github.com/apache/incubator-tvm/pull/5881#discussion_r475869124
##########
File path: src/relay/op/type_relations.cc
##########
@@ -126,6 +126,7 @@ bool BroadcastCompRel(const Array<Type>& types, int
num_inputs, const Attrs& att
return true;
}
}
+ reporter->Assign(types[0], types[1]);
Review comment:
even if you add explicit type? not doing anything is the correct thing,
and i dont think you should do this (look unsound to me) to make the type
checker stronger - probably too strong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
