areusch opened a new pull request #6333:
URL: https://github.com/apache/incubator-tvm/pull/6333
This PR adds a script that automates the process of running dockerized lint
scripts locally, specifically:
- consulting `Jenkinsfile` to determine which docker container to use
- invoking 1 or all of the lint scripts, depending on which ones need to be
fixed up
it also fixes the ASF check to ignore gitignore'd and untracked files
locally, so that the overall process doesn't bomb out if you have an
uncommitted text file in the repo.
a couple of design choices here:
- moved the `make (cpp|py|jni)lint` steps to dedicated scripts in tests/lint
- explicitly avoided adding interactive logic to
`tests/scripts/task_lint.sh`--this should remain simple and readable so it's
clear what the CI does
- maintained existing make targets for backwards-compat with everyone's
workflows
- two changes likely usable for other workflow improvements:
- a script to filter untracked/gitignore'd files
- added `-i` flag to `docker/bash.sh` so that more automation can be
added that supports ctrl+c
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
