jroesch commented on a change in pull request #6336:
URL: https://github.com/apache/incubator-tvm/pull/6336#discussion_r477033674
##########
File path: src/relay/transforms/gradient.cc
##########
@@ -518,22 +533,29 @@ struct ReverseAD : ExprMutator {
orig_var->checked_type_ = call->checked_type();
auto ret = ll->Push(GetRev(call->checked_type(), orig_var, ll));
auto bpv = ll->Push(RefRead(bp));
- Expr nbp = Function({}, LetList::With([&](LetList* ll) {
- tvm::Array<Expr> rev =
- rev_map[op_ref](orig,
GetGrad(call->checked_type(), ret, ll));
- CHECK(args.size() == rev.size());
- for (size_t i = 0; i < args.size(); ++i) {
- UpdateGrad(call->args[i]->checked_type(),
args[i], rev[i], ll);
- }
- return Call(bpv, {});
- }),
- TupleType::Empty(), {});
+ Expr nbp_body = LetList::With([&](LetList* ll) {
+ tvm::Array<Expr> rev = rev_map[op_ref](orig,
GetGrad(call->checked_type(), ret, ll));
+ CHECK(args.size() == rev.size());
+ for (size_t i = 0; i < args.size(); ++i) {
+ UpdateGrad(call->args[i]->checked_type(), args[i], rev[i], ll);
+ }
+ return Call(bpv, {});
+ });
+ Expr nbp = Function({}, nbp_body, TupleType::Empty(), {});
ll->Push(RefWrite(bp, transform::ToANormalForm(nbp)));
// TODO(@M.K.): ToANF should be called on rev. Enhance ToANF for that.
Review comment:
Is this comment still valid? we should add to the TODO list if so
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
