jroesch commented on a change in pull request #6274:
URL: https://github.com/apache/incubator-tvm/pull/6274#discussion_r477047300



##########
File path: src/relay/transforms/type_infer.cc
##########
@@ -98,11 +100,11 @@ class TypeInferencer : private ExprFunctor<Type(const 
Expr&)>,
  public:
   // constructors
 
-  explicit TypeInferencer(IRModule mod, GlobalVar current_func)
+  explicit TypeInferencer(IRModule mod, GlobalVar current_func, 
DiagnosticContext diag_ctx)
       : mod_(mod),
         current_func_(current_func),
-        err_reporter(),
-        solver_(current_func, mod, &this->err_reporter) {
+        diag_ctx(diag_ctx),
+        solver_(current_func, mod, nullptr) {

Review comment:
       This is going to go away, I'm like 50% of the way through fixing the 
type checker. A lot of things have changed since we have designed it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to