junrushao1994 commented on a change in pull request #6347:
URL: https://github.com/apache/incubator-tvm/pull/6347#discussion_r479471092
##########
File path: src/target/llvm/codegen_amdgpu.cc
##########
@@ -228,23 +233,50 @@ inline int DetectROCMApiVersion() {
return 305;
}
-runtime::Module BuildAMDGPU(IRModule mod, std::string target) {
+static void UpdateTargetConfig(const String& key, const String& value,
Review comment:
I feel like the word "canonicalize" is too strong, because it doesn't
really have a canonical form. Maybe "update" is appropriate here, because what
it does is to just update the key-value in the config. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
