tkat0 commented on a change in pull request #6361:
URL: https://github.com/apache/incubator-tvm/pull/6361#discussion_r479772544
##########
File path: docker/install/ubuntu_install_androidsdk.sh
##########
@@ -68,20 +67,20 @@ extras;google;simulators
extras;google;webdriver
extras;m2repository;com;android;support;constraint;constraint-layout;1.0.2
extras;m2repository;com;android;support;constraint;constraint-layout-solver;1.0.2
-lldb;2.3
platforms;android-26
platforms;android-27
tools
-ndk-bundle
+ndk;21.3.6528147
EOF
mkdir /root/.android 2>/dev/null || true
touch /root/.android/repositories.cfg
-(yes || true) | sdkmanager --licenses --sdk_root="$ANDROID_HOME"
+# NOTE: sdkmanager returns exit code 141
+(yes || true) | sdkmanager --licenses --sdk_root="$ANDROID_HOME" | true
Review comment:
similar to https://github.com/facebook/flipper/pull/362
##########
File path: docker/Dockerfile.demo_android
##########
@@ -47,10 +47,7 @@ RUN bash /install/ubuntu_install_androidsdk.sh
COPY install/ubuntu_install_vulkan.sh /install/ubuntu_install_vulkan.sh
RUN bash /install/ubuntu_install_vulkan.sh
-ENV VULKAN_SDK /usr/local/VulkanSDK/1.0.65.0/x86_64
-ENV PATH ${PATH}:${VULKAN_SDK}/bin
-ENV LD_LIBRARY_PATH ${LD_LIBRARY_PATH}:${VULKAN_SDK}/lib
-ENV VK_LAYER_PATH ${VULKAN_SDK}/etc/explicit_layer.d
+ENV VULKAN_SDK=/usr
Review comment:
Same as #5566
##########
File path: docker/install/ubuntu_install_androidsdk.sh
##########
@@ -68,20 +67,20 @@ extras;google;simulators
extras;google;webdriver
extras;m2repository;com;android;support;constraint;constraint-layout;1.0.2
extras;m2repository;com;android;support;constraint;constraint-layout-solver;1.0.2
-lldb;2.3
platforms;android-26
platforms;android-27
tools
-ndk-bundle
+ndk;21.3.6528147
Review comment:
`ndk-bundle` install the latest NDK version.
I specified the currently latest version.
##########
File path: docker/install/ubuntu_install_androidsdk.sh
##########
@@ -68,20 +67,20 @@ extras;google;simulators
extras;google;webdriver
extras;m2repository;com;android;support;constraint;constraint-layout;1.0.2
extras;m2repository;com;android;support;constraint;constraint-layout-solver;1.0.2
-lldb;2.3
Review comment:
I check with `sdkmanager --list`, I Deleted the package that does not
currently exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
