hanke580 commented on a change in pull request #6370:
URL: https://github.com/apache/incubator-tvm/pull/6370#discussion_r482186051



##########
File path: include/tvm/topi/transform.h
##########
@@ -37,6 +40,7 @@
 #include <string>
 #include <unordered_set>
 #include <vector>
+#include <bitset>

Review comment:
       Bitset saves space and is an ideal structure for saving the alphabet in 
the input of einsum "subscript". When implementing the ParseEinsumInput, each 
alphabet is mapped to bitset and could be processed easily in next stage. 
Replacing bitset with int[] or vector seems a little redundant.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to