comaniac commented on a change in pull request #6391:
URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483151525
##########
File path: python/tvm/auto_scheduler/measure.py
##########
@@ -657,9 +692,11 @@ def timed_func():
if error_no == 0:
try:
- # TODO(FrozenGene): Update to ndarray.non-empty.
args = [ndarray.empty(get_const_tuple(x.shape), x.dtype, ctx)
for x in
build_res.args]
+ random_fill =
remote.get_function("tvm.contrib.random.random_fill")
Review comment:
Since currently `USE_RANDOM` is still a config, I would say we should
have such a guard to make the code base more comprehensive. Imagining someone
never updates `build/config.cmake` and his `USE_RANDOM` is OFF, then he may
encounter crashing without a proper message. We can for example simply throw
out a warning saying "USE_RANDOM is OFF and it might lead to inaccurate
measurements" to work around this issue IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
