vegaluisjose opened a new pull request #11:
URL: https://github.com/apache/incubator-tvm-vta/pull/11


   Hi @tmoreau89 @liangfu,
   
   The following PR adds support to export a TCL file from `vta_config.py` with 
all necessary variables for hardware-scripts i.e., Vivado. Currently, these 
variables are captured by invoking `vta_config.py` within the TCL script see 
[here](https://github.com/apache/incubator-tvm-vta/blob/master/hardware/xilinx/scripts/hls.tcl#L35-L49)
 and 
[here](https://github.com/apache/incubator-tvm-vta/blob/master/hardware/xilinx/scripts/vivado.tcl#L39-L64).
 The challenge with this approach is that python environment is unknown in 
hardware tools and we shouldn't rely in that. Instead, we can generate TCL 
which is what natively these tools actually support.
   
   Additionally, I added TCL function called `const` that checks that variables 
are not written (read-only), otherwise it will raise an error. This is a better 
practice than using `set variable value` approach, since these variables are 
not modified in these scripts. Sadly, TCL does not support read-only-variables 
natively. More info about this [here](https://wiki.tcl-lang.org/page/constants).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to