kevinthesun commented on pull request #6449: URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692373767
@zhiics @masahi @t-vi Sure. One major thing in this PR is the handling for dynamic operators such as slice, arange and topk. These ops have dynamic attribute which affects relay type inference. The methodology here is to try to infer these values to make them as static as possible(Similar in tf parser). @masahi suggested we can have an API wrap around ```try except``` blocks. However, the issue is for this method is for different ops the logic inside ```try except``` can be quite different and hard to generate a uniform interface. @t-vi suggested we can check the input type to see whether we need to do such ```try except``` infer_value. Currently we differentiate between relay expr and numerical values. For these dynamic ops, we try to infer value when dynamic attribute is a Relay Expr to see whether it can become a numerical value. For all the subtype under relay Expr, we just call uniform interface of _infer_value to handle them. Any comments or suggestions? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
