tqchen commented on a change in pull request #6494:
URL: https://github.com/apache/incubator-tvm/pull/6494#discussion_r489613598
##########
File path: tests/lint/add_asf_header.py
##########
@@ -149,8 +149,7 @@ def copyright_line(line):
# so that the copyright detector won"t detect the file itself.
if line.find("Copyright " + "(c)") != -1:
return True
- if (line.find("Copyright") != -1 and
- line.find(" by") != -1):
+ if line.find("Copyright") != -1 and line.find(" by") != -1:
Review comment:
Condier change to
```python
# break pattern into two lines to avoid false-negative check
spattern1 = "Copyright"
if line.find(spattern1) != -1 and line.find("by") != -1:
```
##########
File path: tests/lint/check_file_type.py
##########
@@ -164,8 +164,7 @@ def copyright_line(line):
# so that the copyright detector won't detect the file itself.
if line.find("Copyright " + "(c)") != -1:
return True
- if (line.find("Copyright") != -1 and
- line.find(" by") != -1):
+ if line.find("Copyright") != -1 and line.find(" by") != -1:
Review comment:
# break pattern into two lines to avoid false-negative check
spattern1 = "Copyright"
if line.find(spattern1) != -1 and line.find("by") != -1:
##########
File path: tests/lint/check_file_type.py
##########
@@ -164,8 +164,7 @@ def copyright_line(line):
# so that the copyright detector won't detect the file itself.
if line.find("Copyright " + "(c)") != -1:
return True
- if (line.find("Copyright") != -1 and
- line.find(" by") != -1):
+ if line.find("Copyright") != -1 and line.find(" by") != -1:
Review comment:
```
# break pattern into two lines to avoid false-negative check
spattern1 = "Copyright"
if line.find(spattern1) != -1 and line.find("by") != -1:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
