comaniac commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491064115
##########
File path: docs/install/from_source.rst
##########
@@ -174,12 +174,12 @@ Method 1
Set the environment variable `PYTHONPATH` to tell python where to find
the library. For example, assume we cloned `tvm` on the home directory
- `~`. then we can added the following line in `~/.bashrc`.
+ `~` then we can add the following line in `~/.bashrc`.
The changes will be immediately reflected once you pull the code and
rebuild the project (no need to call ``setup`` again)
.. code:: bash
- export TVM_HOME=/path/to/tvm
+ export TVM_HOME=~/tvm
Review comment:
This may cause confusion since it's not necessary to put tvm under
`$HOME`.
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
According to `python/setup.py`, the complete list should also include
`scipy` and `psutil`, but not `pytest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
