hypercubestart commented on a change in pull request #5812:
URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r491477842
##########
File path: src/driver/driver_api.cc
##########
@@ -225,6 +226,7 @@ std::pair<IRModule, IRModule> SplitDevHostFuncs(IRModule
mod_mixed, const Target
BindTarget(target),
tir::transform::LowerWarpMemory(),
tir::transform::Simplify(),
+ tir::transform::LowerCustomDatatypes(),
Review comment:
hi @zhiics thank you for the comment. Here is the data I data gathered
using the script you linked, running purely on graph runtime:
| | Master | CustomDatatypes |
|-------------------------|-----------------|-----------------|
| Resnet18 (cpu, gpu) | 22.19ms, 0.98ms | 21.57ms, 0.98ms |
| Resnet50 (cpu, gpu) | 49.92ms, 2.86ms | 52.53ms, 2.87ms |
| Mobilenet (cpu, gpu) | 8.30ms, 0.70ms | 8.50ms, 0.70ms |
| Inception_v3 (cpu, gpu) | 70.50ms, 6.18ms | 69.97ms, 6.18ms |
so there is no perf impact on the current numbers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
