tqchen commented on a change in pull request #6522:
URL: https://github.com/apache/incubator-tvm/pull/6522#discussion_r492386989
##########
File path: python/tvm/tvmscript/__init__.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script APIs of TVM Python Package, aimed to support TIR"""
+"""TVM Script APIs of TVM Python Package, aimed to support TIR"""
-from .utils import create_module, ashybrid, script
+from .utils import create_module, astvmscript, script
Review comment:
astvmscript is a bit too long, how about asscript
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
The name tvmscript was a bit duplicated since we are already in the tvm
namespace. How about just tvm/script
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Leave it as it is as it was for te.hybrid
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Leave it as it is as the dev guide was for te.hybrid not the tvmscript
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
Yes, because the te.hybrid used to live in that namespace
##########
File path: python/tvm/tvmscript/parser.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""Hybrid Script Parser For TIR"""
+"""TVM Script Parser For TIR"""
Review comment:
I agree there might be some confusion that can can discuss further.
Since API choice itself is quite important -- we need both conciseness and
clarity.
If we want to introduce relay script in the future. Likely we will want to
unify with the current tvm script and call them tvm script directly.
##########
File path: docs/dev/tvm_script.rst
##########
@@ -15,7 +15,7 @@
specific language governing permissions and limitations
under the License.
-Hybrid Frontend Developer Guide
+TVM Script Frontend Developer Guide
Review comment:
I think it refers to
https://github.com/apache/incubator-tvm/tree/master/python/tvm/te/hybrid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
