anijain2305 edited a comment on pull request #6523: URL: https://github.com/apache/incubator-tvm/pull/6523#issuecomment-697949127
Dilation part is good. I am not sure about the conv2d transpose portion. My concern is that we now have to replicate the logic for different framework parsers. My suggestion would be to add `qnn.conv2d_tranpose` op and perform the "dilation + qnn.op.conv2d" lowering in QNN Legalize (example here - https://github.com/apache/incubator-tvm/blob/master/python/tvm/relay/qnn/op/legalizations.py#L266). For now, we can make the transformation for all targets, not just specifically to ARM. This will keep the option open to improve the schedule of conv2d_transpose as a whole if needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
