d-smirnov commented on a change in pull request #6532:
URL: https://github.com/apache/incubator-tvm/pull/6532#discussion_r494840783
##########
File path: python/tvm/relay/op/contrib/arm_compute_lib.py
##########
@@ -337,3 +354,17 @@ def global_avg_pool2d(attrs, args):
if attrs.layout != "NHWC":
return False
return True
+
+
[email protected]_op_attr("add", "target.arm_compute_lib")
[email protected]_op_attr("qnn.add", "target.arm_compute_lib")
+def add(attrs, args):
+ """Check if the external ACL codegen for add should be used."""
+ for typ in [args[0].checked_type, args[1].checked_type]:
+ if typ.dtype not in ["float32", "uint8"]:
Review comment:
1. Yep. The pattern is not needed. Removed.
2. Yep. Has been split
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
