mbrookhart commented on a change in pull request #6351:
URL: https://github.com/apache/incubator-tvm/pull/6351#discussion_r495270303
##########
File path: python/tvm/relay/op/strategy/x86.py
##########
@@ -347,12 +348,20 @@ def dense_strategy_cpu(attrs, inputs, out_type, target):
def batch_matmul_strategy_cpu(attrs, inputs, out_type, target):
"""batch_matmul x86 strategy"""
strategy = _op.OpStrategy()
- strategy.add_implementation(
- wrap_compute_batch_matmul(topi.x86.batch_matmul),
- wrap_topi_schedule(topi.x86.schedule_batch_matmul),
- name="batch_matmul.x86",
- plevel=10,
- )
+ if is_dynamic(out_type):
+ strategy.add_implementation(
Review comment:
Unforunately, it seems like the compile engine can't find any schedules
if I do this:
```
E File
"/home/mbrookhart/repos/mbrookhart_tvm/python/tvm/relay/backend/compile_engine.py",
line 289, in lower_call
E op, call.attrs, inputs, ret_type, target, use_autotvm=False
E File
"/home/mbrookhart/repos/mbrookhart_tvm/python/tvm/relay/backend/compile_engine.py",
line 188, in select_implementation
E best_plevel_impl = max(all_impls, key=lambda x: x.plevel)
E ValueError: max() arg is an empty sequence
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
