comaniac commented on a change in pull request #6612:
URL: https://github.com/apache/incubator-tvm/pull/6612#discussion_r498960080
##########
File path: python/tvm/autotvm/tuner/tuner.py
##########
@@ -174,6 +177,16 @@ def tune(self, n_trial, measure_option,
early_stopping=None, callbacks=(), si_pr
else:
logger.setLevel(old_level)
+ if error_ct == i:
+ _, f = tempfile.mkstemp(prefix="tvm_tuning_", suffix=".log",
text=True)
Review comment:
Better to include "error" in the file name? After all, this file doesn't
contain tuning logs with erros but just error messages.
##########
File path: python/tvm/autotvm/tuner/tuner.py
##########
@@ -174,6 +177,16 @@ def tune(self, n_trial, measure_option,
early_stopping=None, callbacks=(), si_pr
else:
logger.setLevel(old_level)
+ if error_ct == i:
+ _, f = tempfile.mkstemp(prefix="tvm_tuning_", suffix=".log",
text=True)
Review comment:
Better to include "error" in the file name? After all, this file doesn't
contain tuning logs with errors but just error messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
