csullivan commented on a change in pull request #6616:
URL: https://github.com/apache/incubator-tvm/pull/6616#discussion_r499001120
##########
File path: tests/python/topi/python/test_topi_batch_matmul.py
##########
@@ -67,10 +67,13 @@ def check_device(device, ctx):
@tvm.testing.uses_gpu
def test_batch_matmul():
- verify_batch_matmul(1, 16, 16, 32)
- verify_batch_matmul(5, 16, 16, 32)
- verify_batch_matmul(5, 16, 20, 32)
- verify_batch_matmul(30, 16, 20, 32)
+ verify_batch_matmul(1, 1, 16, 16, 32)
+ verify_batch_matmul(5, 5, 16, 16, 32)
+ verify_batch_matmul(5, 5, 16, 20, 32)
+ verify_batch_matmul(30, 30, 16, 20, 32)
+ # Test batch broadcasting.
+ verify_batch_matmul(1, 5, 16, 16, 32)
+ verify_batch_matmul(5, 1, 16, 16, 32)
Review comment:
Consider adding a test that ensures the incorrect use case is handled as
expected, e.g. xb=2, yb=5.
##########
File path: tests/python/topi/python/test_topi_dense.py
##########
@@ -75,6 +75,8 @@ def check_device(device, ctx):
b = tvm.nd.array(b_np, ctx)
c = tvm.nd.array(c_np, ctx)
d = tvm.nd.array(np.zeros(get_const_tuple(D.shape), dtype=dtype),
ctx)
+ print(tvm.lower(s, [A, B, C, D], simple_mode=True))
+ exit()
Review comment:
```suggestion
```
Remove debug lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
