jroesch commented on a change in pull request #6274:
URL: https://github.com/apache/incubator-tvm/pull/6274#discussion_r499061178
##########
File path: src/ir/module.cc
##########
@@ -247,8 +227,8 @@ void IRModuleNode::AddTypeDef(const GlobalTypeVar& var,
const TypeData& type, bo
AddTypeDefUnchecked(var, type, update);
// need to kind check at the end because the check can look up
// a definition potentially
- CHECK(relay::KindCheck(type, GetRef<IRModule>(this)) == TypeKind::kTypeData)
- << "Invalid or malformed typedata given to module: " << type;
+ // CHECK(relay::KindCheck(type, GetRef<IRModule>(this)) ==
TypeKind::kTypeData)
+ // << "Invalid or malformed typedata given to module: " << type;
Review comment:
I opened a tracking issue for the kind checking issues, and did some of
the refactors on this branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
