mbrookhart commented on a change in pull request #6533:
URL: https://github.com/apache/incubator-tvm/pull/6533#discussion_r499885677
##########
File path: tests/python/relay/test_op_level3.py
##########
@@ -903,8 +904,8 @@ def verify_scatter(dshape, ishape, axis=0):
indices_np = np.random.randint(-dshape[axis], dshape[axis] - 1,
ishape).astype("int64")
ref_res = ref_scatter(data_np, indices_np, updates_np, axis)
- # TODO(mbrookhart): expand testing when adding more backend schedules
- for target, ctx in [("llvm", tvm.cpu())]:
+
Review comment:
Hmm, that's a good idea. I'm not sure the dyn namespace is the right
place though? Maybe just add a second test with dynamic shapes here? or in
test_any?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
