ANSHUMAN87 commented on a change in pull request #6580:
URL: https://github.com/apache/incubator-tvm/pull/6580#discussion_r501061630
##########
File path: python/tvm/tir/ir_builder.py
##########
@@ -62,9 +62,10 @@ class BufferVar(ObjectGeneric):
IRBuilder.allocate
"""
- def __init__(self, builder, buffer_var, content_type):
+ def __init__(self, builder, buffer_var, shape, content_type):
Review comment:
I have one query here. What happens if we don't have the shape info. In
that case, how do you enforce the check in _linear_index ?
For example: We create a buffer pointer out of certain existing buffer, in
that case you may not have necessarily the shape info, in that case, how it
works ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
